-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an input flag to configure diff output in code style checks #599
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a great idea! Thanks @viseshrp !
Thank you! How often do you guys make releases of ansys/actions? Thanks. |
In this case, as soon as it gets merged (and I fix another coming up PR) I will do a patch release :) v8 will be updated today |
Waiting on #600 to release |
New version released! If you consume |
Awesome. Thank you |
@RobPasMue Sorry for the late response, but I cannot get this to work: I still see the diff on failure. |
Can you share a CI/CD log where this is happening so that I can pull the thread and investigate? =) |
@RobPasMue https://github.com/ansys/pydynamicreporting/actions/runs/11335692082/job/31524324550 |
@RobPasMue sorry for the confusion, I think bash somehow casts the bool to a string. Everything looks and works fine. Please ignore my comments. |
Hello!
Most of the time, our use case does not require the --show-diff-on-failure flag which when turned on, it produces a large diff of unwanted output that pollutes the action logs. Thereby, I'd like to propose a flag to turn it off but keep it on by default.