Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an input flag to configure diff output in code style checks #599

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

viseshrp
Copy link
Contributor

@viseshrp viseshrp commented Oct 4, 2024

Hello!
Most of the time, our use case does not require the --show-diff-on-failure flag which when turned on, it produces a large diff of unwanted output that pollutes the action logs. Thereby, I'd like to propose a flag to turn it off but keep it on by default.

@viseshrp viseshrp requested a review from a team as a code owner October 4, 2024 07:54
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label Oct 4, 2024
@viseshrp viseshrp changed the title Add an input flag to configure diff output in code style checks feat: Add an input flag to configure diff output in code style checks Oct 4, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great idea! Thanks @viseshrp !

@viseshrp
Copy link
Contributor Author

viseshrp commented Oct 4, 2024

Sounds like a great idea! Thanks @viseshrp !

Thank you! How often do you guys make releases of ansys/actions? Thanks.

@RobPasMue
Copy link
Member

Sounds like a great idea! Thanks @viseshrp !

Thank you! How often do you guys make releases of ansys/actions? Thanks.

In this case, as soon as it gets merged (and I fix another coming up PR) I will do a patch release :) v8 will be updated today

@RobPasMue RobPasMue merged commit d5877c6 into main Oct 4, 2024
14 checks passed
@RobPasMue RobPasMue deleted the feat/show-diff-opt branch October 4, 2024 08:40
@RobPasMue
Copy link
Member

Waiting on #600 to release

@RobPasMue
Copy link
Member

New version released! If you consume v8 you should get your changes @viseshrp

@viseshrp
Copy link
Contributor Author

viseshrp commented Oct 4, 2024

New version released! If you consume v8 you should get your changes @viseshrp

Awesome. Thank you

@viseshrp
Copy link
Contributor Author

@RobPasMue Sorry for the late response, but I cannot get this to work:

image

I still see the diff on failure.
I am not sure what other changes are required or if I'm doing this the wrong way. Any thoughts?

@RobPasMue
Copy link
Member

Can you share a CI/CD log where this is happening so that I can pull the thread and investigate? =)

@viseshrp
Copy link
Contributor Author

@RobPasMue https://github.com/ansys/pydynamicreporting/actions/runs/11335692082/job/31524324550
I think this may be my misunderstanding and it may actually work.
The check here maybe incorrect even though it works. Should the input value mentioned here be in quotes to make sure the comparison is correct? It's comparing boolean against a string, if I'm right?

image

@viseshrp
Copy link
Contributor Author

If that is indeed the problem, one of your existing steps do the same too, so I guess it isn't?

image

@viseshrp
Copy link
Contributor Author

viseshrp commented Oct 21, 2024

@RobPasMue sorry for the confusion, I think bash somehow casts the bool to a string. Everything looks and works fine. Please ignore my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants